Skip to content

Update init-letsencrypt.sh #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update init-letsencrypt.sh #89

wants to merge 3 commits into from

Conversation

pcarioufr
Copy link

Thanks for this :-) 👍 It was really helpful !

I think this would help:

  • fix loop on domains for dummy certificates
  • create bigger SSH Key (4096) as 1024 would fail with current nginx version

@pcarioufr
Update init-letsencrypt.sh
8cdb071 
fix loop on domains for dummy certificates
@pcarioufr
Update init-letsencrypt.sh
40cdf45
@pcarioufr pcarioufr marked this pull request as draft September 5, 2020 20:48
@williamforster
Copy link

Thanks for the guide, +1 to changing ssh key to 4096, nginx does not accept key at current length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ash0080 ash0080 ash0080 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcarioufr @williamforster @ash0080